I may be missing something but why can't you use the previewStateMachienCommand.execute here still? You should be able to pass in the URI now

Also, it may be helpful to enhance openTextDocument as needed:

instead of calling 'vscode.openWith' directly. That allows us to (potentially) instrument that or improve it in the future.

I may be missing something but why can't you use the previewStateMachienCommand.execute here still? You should be able to pass in the URI now

I initially tried to use previewStateMachineCommand.execute directly, however since I now call downloadStateMachineDefinition directly in the previewStateMachineCommand, it creates a circular dependency which fails the build.

Also, it may be helpful to enhance openTextDocument as needed:

aws-toolkit-vscode/packages/core/src/shared/utilities/workspaceUtils.ts

Line 206 in cc0455f

export async function openTextDocument(filenameGlob: vscode.GlobPattern): Promise<vscode.TextDocument | undefined> {

instead of calling 'vscode.openWith' directly. That allows us to (potentially) instrument that or improve it in the future.

I think openTextDocument is not quite the interface we want to use/overload, since it seems to primarily be used for searching for a file to open, while in this case we want to open a specific URI.

I can instead refactor out vscode.openWith(uri, WorkflowStudioEditorProvider.viewType, ...) however, since we have been repeating that pattern a few times.

I can instead refactor out vscode.openWith(uri, WorkflowStudioEditorProvider.viewType, ...) however, since we have been repeating that pattern a few times.

🚀